Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_addedScriptHashesCleanInterval is not cleared if connection is closed by retryStrategy #1381

Closed
samimakicc opened this issue Jul 7, 2021 · 3 comments

Comments

@samimakicc
Copy link

_addedScriptHashesCleanInterval is not cleared If connection to redis is lost and retryStrategy is not a function or retryStrategy returns something else than a number.
This active timeout/interval causes node process unable to terminate when it should.

#1219 fixed that _addedScriptHashesCleanInterval is cleared when connection is manually closed with redis.disconnect() or redis.quit() but I feel it should also be cleared if the connection is closed by other means.

@shaharmor
Copy link
Collaborator

@samimakicc would you mind creating a PR?

@taratyn-tc
Copy link

I'm also experiencing and I can't figure out how to fix this. I'm happy to contribute a code fix, if I can get some advice how to fix it.

@marcbachmann
Copy link
Collaborator

We've fixed that in ioredis v5 by tracking the scripts per redis connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants