Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to refresh slots cache #474

Closed
damianhodgkiss opened this issue May 29, 2017 · 5 comments
Closed

Failed to refresh slots cache #474

damianhodgkiss opened this issue May 29, 2017 · 5 comments

Comments

@damianhodgkiss
Copy link
Contributor

damianhodgkiss commented May 29, 2017

yep, have read the other issues.. we are using AWS redis CLUSTER and it does work fine after the initial attempts.. our issue is we are seeing Failed to refresh slots cache the first time our scripts run because of a low timeout (we are connecting to multiple redis stores for different purposes which may be contributing to needing a slightly higher timeout)

https://github.com/luin/ioredis/blob/master/lib/cluster/index.js#L585-L612

the slots command being issued has a hardcoded 1,000ms timeout which doesn't seem to be enough in some cases. Modifying the timeout in node_modules... to 10,000ms rids the error but doesn't work for our deployment scenario unless we fork the module so just wondering if we can get a config variable for this timeout?

@shaharmor
Copy link
Collaborator

Sound reasonable. Care to make a PR?

@damianhodgkiss
Copy link
Contributor Author

damianhodgkiss commented May 29, 2017

can do.. any preferences what you'd like the option called so it keeps with your option naming? else maybe just refreshSlotsTimeout (on the main cluster config/options)

@shaharmor
Copy link
Collaborator

slotsRefreshTimeout should be good. @luin ?

@luin
Copy link
Collaborator

luin commented May 29, 2017

@shaharmor Sounds good to me.

@luin
Copy link
Collaborator

luin commented May 30, 2017

Released with v3.1.0 🍻

@luin luin closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants