Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the LCS command and deprecate STRALGO #2987

Open
tishun opened this issue Sep 13, 2024 · 2 comments · May be fixed by #3037
Open

Implement the LCS command and deprecate STRALGO #2987

tishun opened this issue Sep 13, 2024 · 2 comments · May be fixed by #3037
Labels
status: good-first-issue An issue that can only be worked on by brand new contributors status: help-wanted An issue that a contributor can help us with type: feature A new feature

Comments

@tishun
Copy link
Collaborator

tishun commented Sep 13, 2024

Feature Request

Deprecate the STRALGO command and implement the LCS in its place

Is your feature request related to a problem? Please describe

With redis/redis#9744 the STRALGO command was deprecated in Redis 7.0
Tests that test the STRALGO command have not been running since the pipeline only uses latest Redis versions

Describe the solution you'd like

Implement the LCS command

Describe alternatives you've considered

For users of the Lettuce driver the only possible solution now is to use the Custom commands
@tishun tishun mentioned this issue Sep 13, 2024
Merged
@tishun tishun added type: feature A new feature status: help-wanted An issue that a contributor can help us with status: good-first-issue An issue that can only be worked on by brand new contributors labels Oct 18, 2024
@tishun
Copy link
Collaborator Author

tishun commented Oct 24, 2024

See also #2970

@Dltmd202 Dltmd202 linked a pull request Oct 31, 2024 that will close this issue
Open
4 tasks
@injae-kim
Copy link

PR: #3037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: good-first-issue An issue that can only be worked on by brand new contributors status: help-wanted An issue that a contributor can help us with type: feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate the STRALGO command and implement the LCS in its place Dltmd202/lettuce
2 participants
@tishun @injae-kim