Moj/otomi chart #35
Merged
Moj/otomi chart #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-zimnowoda
requested changes
Jun 17, 2021
Morriz
reviewed
Jun 17, 2021
Morriz
suggested changes
Jun 17, 2021
j-zimnowoda
requested changes
Jun 18, 2021
j-zimnowoda
approved these changes
Jun 22, 2021
|
@j-zimnowoda why do you approve a non working solution? |
|
And maybe we should start a PR in "draft" mode so it can't be approved @mojtabaimani |
@Morriz I saw it working and it passed my code review. Draft mode it is not a solution. We still need to invest in integration test framework, because it is not possible to test each PR manually. |
Morriz
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a task to map a plain values.yaml from otomi chart to different value files and merge with current bootstrapped ones.