Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL_BYPASS_UPDATE_HOOK is not set in 1.2.0 #605

Closed
baby-gnu opened this issue May 30, 2016 · 1 comment
Closed

GL_BYPASS_UPDATE_HOOK is not set in 1.2.0 #605

baby-gnu opened this issue May 30, 2016 · 1 comment
Assignees
Labels

Comments

@baby-gnu
Copy link

Hello,

I tried to setup the fix for Hook errors while pushing over HTTPS but it does not work.

I found a topic on redmine forum which explain the problem and the fix.

Regards.

@baby-gnu
Copy link
Author

This is not mandatory any more:

diff --git a/lib/grack/server.rb b/lib/grack/server.rb
index eb8af96..163af91 100644
--- a/lib/grack/server.rb
+++ b/lib/grack/server.rb
@@ -153,6 +153,7 @@ module Grack
       def smart_http_args
         [
           'env',
+          "GL_BINDIR=gitolite/src",
           "GL_LIBDIR=#{RedmineGitHosting::Config.gitolite_lib_dir_path}",
           "GL_REPO=#{repository_object.gitolite_repository_name}",
           "GL_USER=#{@env['REMOTE_USER']}"

And everything is working fine:

  • push by SSH triggers the redmine_git_hosting hooks
  • push by HTTPs triggers the gitolite hooks (which was not the case before, at least with 0.6.3)

@n-rodriguez n-rodriguez self-assigned this Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants