Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option of allowing the breaking change if the pom versions major have increased #23

Open
anders4work opened this issue Feb 18, 2022 · 4 comments

Comments

@anders4work
Copy link

Hi again

It would be a very nice feature if the plugin could be configured to only break the build if the breaking change was not flagged via an increase in the major version of the pom.

That is:
If the new flag, say useSemanticVersioning, is set to true then the plugin should examine if A) the pom version number seems to adhere to the standards of semantic versioning and B) if there has been an increase in the major version as compared to the previous version against which the breaking changes check is performed. If the major version has been increased the developer seems aware of the breaking change for which reason the plugin should allow the build to pass.

@galovics
Copy link
Member

Hi @anders4work,

Makes sense. Essentially what you're saying is the breaking change check could be entirely skipped in case of a major version upgrade (?).

Or would it make sense to still do the check but not fail the build in case of backward incompatible changes - kind of like as a warning?

@anders4work
Copy link
Author

Yes exactly.
And yes - I think that it is a very good idea to still run the check but instead of breaking the build emit some warning/info about the changes!

@galovics
Copy link
Member

Alright, I'll take a look soon. Do you need this urgently?

@anders4work
Copy link
Author

Sorry for late reply, been a bit busy. No it is not urgent, just a very nice feature I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants