Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue reduct-py-40 #43

Merged
merged 7 commits into from
Oct 18, 2022
Merged

Fix for issue reduct-py-40 #43

merged 7 commits into from
Oct 18, 2022

Conversation

aschenbecherwespe
Copy link
Collaborator

@aschenbecherwespe aschenbecherwespe commented Oct 17, 2022 •
edited
Loading

Closes #40

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

  • Changes the interface of bucket.read to return Records inside an asynccontext.
  • Removes the bucket.read_by method, which has been functionally replaced by bucket.query.

What is the current behavior?

Currently read and read_by return raw bytes.

What is the new behavior?

read now returns a Record, which has object metadata, along with async methods to retrieve the raw data either entirely or iteratively as chunks.

Does this PR introduce a breaking change?

  • bucket.read_by has been removed
  • bucket.read now returns a Record

Other information:

@aschenbecherwespe aschenbecherwespe changed the title Reduct py 40 Fix for issue reduct-py-40 Oct 17, 2022
atimin
atimin approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@aschenbecherwespe aschenbecherwespe merged commit fc4f1f9 into main Oct 18, 2022
@aschenbecherwespe aschenbecherwespe deleted the reduct-py-40 branch October 18, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atimin atimin atimin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change: Bucket.read returns Record
2 participants
@aschenbecherwespe @atimin