Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No detail in ReductError exception #51

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

aschenbecherwespe
Copy link
Collaborator

@aschenbecherwespe aschenbecherwespe commented Nov 3, 2022

Closes #50

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Uses HEAD to discover bucket existence, but on error gets no error message since HEAD returns no body.

What is the new behavior?

Uses GET to discover bucket existence, so that we can use the error message from the response body.

Does this PR introduce a breaking change?

Nope.

Other information:

@aschenbecherwespe aschenbecherwespe self-assigned this Nov 3, 2022
@aschenbecherwespe aschenbecherwespe linked an issue Nov 3, 2022 that may be closed by this pull request
1 task
@atimin atimin changed the title 50 bug no detail in reducterror exception No detail in ReductError exception Nov 4, 2022
pkg/reduct/client.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@aschenbecherwespe aschenbecherwespe merged commit 65a0445 into main Nov 4, 2022
@aschenbecherwespe aschenbecherwespe deleted the 50-bug-no-detail-in-reducterror-exception branch November 4, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No detail in ReductError exception
2 participants