Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error/confusion: const {configureStore} vs import configureStore #152

Open
jayands opened this issue Jun 27, 2018 · 1 comment

Comments

@jayands
Copy link

jayands commented Jun 27, 2018

I mean, it could be that you are indeed exporting both, but it'd be a lot less confusing if you exported one instead and the documentation reflected that.

import { configureStore } from 'redux-mock-store' //ES6 modules
const { configureStore } = require('redux-mock-store') //CommonJS
/* or */
import configureStore from 'redux-mock-store' //ES6 modules
const configureStore = require('redux-mock-store') //CommonJS
@jednano
Copy link

jednano commented Jul 12, 2019

I cleaned this up in my TypeScript fork with a circular default prop. See the relevant tests.

See also: #148 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants