-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading redux-toolkit from 1.2.5 gave stack trace on saga put() #671
Comments
Any chance you have multiple versions of Immer in your app after an upgrade? |
>>>> Mark Erikson ***@***.***>:
Any chance you have multiple versions of Immer in your app after an upgrade?
Yes, I have two versions of Immer, but I had that both before and after the upgrade.
The other version of Immer is 1.10 and the dependecy comes from
react-dev-utils 10.2.1.
Before the upgrade @reduxjs/toolkit pulled in immer 4.0.2.
After bumping @reduxjs/toolkit to 1.4.0 and rebuilding, @reduxjs/toolkit
pulled in immer 7.0.7
react-dev-utils pulled in immer 1.10 in both cases (I don't even know
where the stuff that pulls in react-dev-utils resides, because it's
nothing in the app outside of package-lock.json).
Thanks!
|
Yeah, I'd filed an issue against CRA a while back that their version of Immer was wayyyy out of date: facebook/create-react-app#8750 That just got closed and I would assume the fix should be out in the next release (CRA 3.4.2?) Does use of RTK 1.4 + Immer 7 fix the issue, or is that still happening? |
>>>> Mark Erikson ***@***.***>:
Yeah, I'd filed an issue against CRA a while back that their version of Immer was wayyyy out of date:
facebook/create-react-app#8750
That just got closed and I would assume the fix should be out in the next release (CRA 3.4.2?)
Ok, thanks for the info and update.
Does use of RTK 1.4 + Immer 7 fix the issue, or is that still happening?
I tried explictly depending on immer 7 like this, in package.json:
"dependencies": {
...
"@reduxjs/toolkit": "^1.4.0",
"immer": "^7.0.7",
"terser": "^4.8.0"
},
Unfortunately, that didn't help.
I also tried using npm-force-resolutions, to force immer to version 7,
but I was unable to get npx to work with frontend-maven-plugin, which is
what I use to create and deliver bundle.js.
So, I guess I'm stuck with RTK 1.2.5, until CRA fixes their immer
dependency.
Thanks!
|
I know that Yarn has a Since there doesn't seem to be anything else actionable on our end, I'll go ahead and close this. |
When I tried upgrading redux-toolkit from 1.2.5 to 1.4.0 today, I got the following stack trace:
Immer error 19 referred to in the stack trace, is "plugin not loaded"
The error occurs already at 1.3.0 and downgrading redux-toolkit in package.json doesn't fix the problem.
If I restore the package-lock.json file from before upgrading redux-toolkit from 1.2.5, the problem goes away.
The text was updated successfully, but these errors were encountered: