Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatching action from iframe to store defined in parent window always throws #304

Closed
michalkvasnicak opened this issue Jul 23, 2015 · 4 comments
Labels

Comments

@michalkvasnicak
Copy link
Contributor

Dispatching an action from an iframe to store defined in a parent window always throws Invariant Violation: Actions must be plain objects. Use custom middleware for async actions.

It fails on the check Object.getPrototypeOf(obj) === Object.prototype in isPlainObject.

Only way to fix this is to expose actions in the parent window.

@michalkvasnicak michalkvasnicak changed the title Dispatching action from iframe to store defined in parent window Dispatching action from iframe to store defined in parent window always throws Jul 23, 2015
@gaearon gaearon added this to the 1.0 milestone Jul 23, 2015
@gaearon gaearon added the bug label Jul 23, 2015
@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2015

Bah! I knew we'd hit something like this :-P
Is there an iframe-friendly plain object check? What is lodash doing?

@michalkvasnicak
Copy link
Contributor Author

I'll take a look. Just a minute.

@michalkvasnicak
Copy link
Contributor Author

Ok lodash is fine. So now we need to figure out what to do so it will behave the same.

This was referenced Jul 23, 2015
@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2015

Should be fixed by #306!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants