Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: this.getData is not a function #1233

Closed
4 tasks done
AlexWayfer opened this issue Sep 19, 2023 · 4 comments
Closed
4 tasks done

TypeError: this.getData is not a function #1233

AlexWayfer opened this issue Sep 19, 2023 · 4 comments
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Comments

@AlexWayfer
Copy link

Initial checklist

Affected packages and versions

Something indirect, probably new versions of remark-parse due to logs

Link to runnable example

No response

Steps to reproduce

I've received remark-cli and remark-gfm (doesn't matter I guess) from Depfu.

And I've noticed fails in Cirrus CI.

In this project were no fails in PRs, but they become after manual push to the main:
https://cirrus-ci.com/task/6402074150174720?logs=lint#L12

In this project are fails in PRs:
AlexWayfer/flame-sentry_context#6

I had no errors locally, so I believe it depends on package-lock.json (and CI cache).

I've saved the old lock file: (oh, thanks GitHub, JSON files are too dangerous for you)
package-lock.json.old.zip

And after npm update I've got the error locally, the package-lock.json is here:
package-lock.json.zip

Node.js v20.7.0, npm v10.1.0 (there are no new versions in your issue template)

Expected behavior

No errors from indirect dependencies.

Actual behavior

There is error:

> remark -f .
CHANGELOG.md
: no issues found
LICENSE.md
: no issues found
README.md
error
Cannot process file
[cause]
:
    TypeError: this.getData is not a function
    at Object.exitCodeText (file:///tmp/cirrus-ci-build/node_modules/mdast-util-gfm-table/lib/index.js:121:12)
    at compile (file:///tmp/cirrus-ci-build/node_modules/remark-parse/node_modules/mdast-util-from-markdown/lib/index.js:337:40)
    at fromMarkdown (file:///tmp/cirrus-ci-build/node_modules/remark-parse/node_modules/mdast-util-from-markdown/lib/index.js:173:27)
    at parser (file:///tmp/cirrus-ci-build/node_modules/remark-parse/lib/index.js:33:12)
    at Function.parse (file:///tmp/cirrus-ci-build/node_modules/unified/lib/index.js:668:12)
    at parse (file:///tmp/cirrus-ci-build/node_modules/unified-engine/lib/file-pipeline/parse.js:59:36)
    at wrapped (file:///tmp/cirrus-ci-build/node_modules/trough/index.js:115:27)
    at next (file:///tmp/cirrus-ci-build/node_modules/trough/index.js:65:23)
    at done (file:///tmp/cirrus-ci-build/node_modules/trough/index.js:148:7)
    at file:///tmp/cirrus-ci-build/node_modules/unified-engine/lib/file-pipeline/read.js:49:7

Runtime

Other (please specify in steps to reproduce)

Package manager

Other (please specify in steps to reproduce)

OS

Linux

Build and bundle tools

Other (please specify in steps to reproduce)

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 19, 2023
@wooorm
Copy link
Member

wooorm commented Sep 19, 2023

Update both projects at the same time and it should work right now.

It takes time to go through the ecosystem. Wait a bit for the dust to settle :)

@AlexWayfer
Copy link
Author

Nevermind, I've somehow messed up and there actually was remark-gfm v3, not v4. My bad, sorry.

@github-actions

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Sep 19, 2023

No worries! :)

@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Sep 19, 2023
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants