Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile not set when used as a unified plugin #1236

Closed
siefkenj opened this issue Oct 1, 2023 · 4 comments
Closed

Compile not set when used as a unified plugin #1236

siefkenj opened this issue Oct 1, 2023 · 4 comments
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on

Comments

@siefkenj
Copy link

siefkenj commented Oct 1, 2023 •
edited
Loading

It appears that remark-stringify sets this.compiler rather than this.Compiler, which prevents this plugin from working in Unifiedjs 10.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 1, 2023
@ChristianMurphy
Copy link
Member

Welcome @siefkenj!
Sorry you ran into some confusion.
The latest version of remark-stringify v11, is compatible with unified v11.
The change to lowercase compiler is explained here unifiedjs/unified@8e57478

The solution is the match your version of remark to your version of unified.
10 with 10, or 11 with 11, not mixing incompatible versions.

Also for future reference, please do not skip or erase the issue template, it has information which helps maintainers and community members better support you.

@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2023
@ChristianMurphy ChristianMurphy added the 🙋 no/question This does not need any changes label Oct 1, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 1, 2023
@siefkenj
Copy link
Author

siefkenj commented Oct 1, 2023

Thank you for the information :-).

Would you be open to supporting both versions 10 and 11 of unified? It seems like it would not cause an issue to add this.Compiler = ... as well.

@ChristianMurphy
Copy link
Member

Would you be open to upgrade to unified v11? 🙂
The unified/remark upgrade cleaned up unused and deprecated APIs, re-adding those deprecated APIs for no discernible reason, is a no for me.
If there is a particular reason why you do not want to upgrade, or a roadblock to upgrading, please share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siefkenj @ChristianMurphy