Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring needed in ExoGAINS data input #386

Open
Renato-Rodrigues opened this issue May 5, 2021 · 0 comments
Open

Refactoring needed in ExoGAINS data input #386

Renato-Rodrigues opened this issue May 5, 2021 · 0 comments
Labels
bug Something isn't working code cleaning Code that could/should be cleaned up

Comments

@Renato-Rodrigues
Copy link
Member

Renato-Rodrigues commented May 5, 2021

@rauner @jhilaire
This code link in exoGAINS uses the fe_tax_sub_sbi to calculate, as far as I understood, sector shares on final energies.

However, this tax specific set will be removed very soon from the code due to a change on the final energy tax code.
Also, if your intention is to have FE shares, using the vm_cesIO is not the correct way as it would probably not work properly in different module realizations that use useful energy or services instead of final energy at the CESIO level.

Would one of you be able to refactor this code to use instead other way to calculate the needed shares?

You could probably do it very straightforward by using the variable vm_demFeSector. This variable includes the final energy carriers and the sector information, and it is already used in other parts of the model to similar purposes, like for example, in the q_shfe equation that calculates final energy carrier shares in the sector total final energy.

@Renato-Rodrigues Renato-Rodrigues added code cleaning Code that could/should be cleaned up bug Something isn't working labels May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code cleaning Code that could/should be cleaned up
Projects
None yet
Development

No branches or pull requests

1 participant