Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History.push() and replace() not working in React while using [email protected] #834

Closed
AnkitAvi11 opened this issue Sep 21, 2020 · 3 comments

Comments

@AnkitAvi11
Copy link

No description provided.

@StringEpsilon
Copy link

StringEpsilon commented Sep 21, 2020

Duplicate of #803 / #805 / #811

The break is pretty much intentional, just not documented in the release notes.

@AnkitAvi11
Copy link
Author

Duplicate of #803 / #805 / #811

The break is pretty much intentional, just not documented in the release notes.

Is there any way I can work around it without going back to the previous stable version ?

@StringEpsilon
Copy link

What breaks is actually the way the listeners are called. Unless you can adapt whatever is listening to the new calling conventions, you either have to make some wrapper (by overriding .listen(), maybe?) or downgrade.

I tried to collect what I could about the technical changes in this gist: https://gist.github.com/StringEpsilon/47820cc961c8d82f3b71dc856b5cc616 Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants