You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All of the tests in the "TestSequences" folder only test against history.location, but there is currently "no guarantee" that the location is actually reflected in the window.location.
In my PR to solve Issue #912, I noticed there is currently no test of the relationship between the two location states. That PR therefore happens to include a general fix for this issue. If PR #911 is ultimately rejected, this issue could be solved with a new PR just with this:
Expected behavior
Tests should ensure
window.location
is correctly modified.Actual behavior
Test sequences only test against
history.location
Details
For
HashHistory
, "window.location" and "history" should be related as follows:All of the tests in the "TestSequences" folder only test against
history.location
, but there is currently "no guarantee" that the location is actually reflected in thewindow.location
.In my PR to solve Issue #912, I noticed there is currently no test of the relationship between the two location states. That PR therefore happens to include a general fix for this issue. If PR #911 is ultimately rejected, this issue could be solved with a new PR just with this:
added to
packages/history/__tests__/hash-test.js
The text was updated successfully, but these errors were encountered: