Cookies set in thrown responses are ignored when the CatchBoundary is in a parent route

[eranhirsch]

What version of Remix are you using?

1.4.3

Steps to Reproduce

1. Create a new remix app using npx create-remix and use the Just the basics and Remix App Server settings
2. Create the parent layout ~/app/routes/parent.tsx:

export function CatchBoundary() {
  return <main>I'm a catch</main>;
}

export default function Parent() {
  return (
    <main>
      <header>Parent</header>
      <Outlet />
    </main>
  );
}

3. Create the child ~/app/routes/parent/child.tsx:

export const loader: LoaderFunction = ({ request }) => {
  if (new URL(request.url).searchParams.has("throw")) {
    throw json(null, { headers: { "Set-Cookie": "thrownCookie=DoesntWork" } });
  }
  return json(null, { headers: { "Set-Cookie": "regularFlowCookie=ThisWorks" } });
};

export default function Child() {
  return <section>Child</section>;
}

4. Run the server npm run dev
5. curl --head "localhost:3000/parent/child"
6. curl --head "localhost:3000/parent/child?throw"

Expected Behavior

The Set-Cookie header should be shown in both cases

Actual Behavior

When the response is thrown in a child of a CatchBoundary, Set-Cookie headers are not copied

[eranhirsch]

This happens because of
https://github.com/remix-run/remix/blob/main/packages/remix-server-runtime/server.ts#L404
which filters out the modules below the CatchBoundary.

Because that filtered prefix of routes is the one used to generate the headers:
https://github.com/remix-run/remix/blob/main/packages/remix-server-runtime/server.ts#L434-L439

The problem is that, at this stage of the response logic, we don't track that a loader response was thrown or if it was returned in a happy flow (except logging the catch itself and the response data and status). So while it makes sense to skip the data (and headers) of child loaders that ran successfully, as they would be irrelevant because of the CatchBoundary at their parent, the thrown response should be treated as if it is "rendered" (it is what the CatchBoundary "catches") so it's headers should be handled too.

[brophdawg11]

Fixed by #6475 and will be available in the next release (likely 1.17.0)

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-33cc4c0-20230525 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[eranhirsch]

wow, it's been a year! thanks for circling back to the task to update! Waiting for the next release to remove my patched solution

[github-actions]

🤖 Hello there,

We just published version 1.17.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.17.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!