AppLoadContext type augmentation requires undefined check

[justinwaite]

What version of Remix are you using?

1.6.8

Steps to Reproduce

Augment the server-runtime module and declare properties on the AppLoadContext interface

declare module "@remix-run/server-runtime" {
  interface AppLoadContext {
    userId: number;
  }
}

Expected Behavior

I would expect that to be able to use context without doing any null/undefined checks, since I've written the "guarantee" that I indeed have this context in my app.

export async function loader({context}: LoaderArgs) {
  getSomeData(context.userId); // I would like to be able to do this
}

Actual Behavior

Because the type for context is AppLoadContext | undefined in the loader and action args, theres' no way that I know of to tell typescript that it will never be undefined. This means that whenever you wish to use context, you must either assert its existence with ! , or you must actually check that it exists to make typescript happy.

export async function loader({context}: LoaderArgs) {
  getSomeData(context!.userId); // but instead I have to do this
}

export async function loader({context}: LoaderArgs) {
  invariant(context); // or this
  getSomeData(context.userId);
}

[justinwaite]

I had a hard time trying to decide if this should be an issue or a discussion, so I chose issue. Let me know if I'm wrong!