-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 routing doesn't detect new routes #5247
Comments
unfortunately i'm unable to reproduce with your repo both the CLI and browser pick up the new file
|
Tested on different environments, seems to be a Windows-specific bug: ✔️ StackBlitz |
hm, i'll pull windows up shortly and see what i can come up with thanks for debugging! probably has to do with fast-glob and windows style paths, but i'll confirm here in a few |
yep, fast glob will return posix style paths |
I'm still seeing this issue on Windows. Has the fix been released? |
I'm seeing it as well |
it seems to be hit or miss on when it reloads for some reason as creating 2 files does trigger it for me and other times it works every time... - looking into it this time it is not a path separator issue though 😉 @pcattori is working on compiler updates, so please try the |
@mcansh, Unfortunately, nothing has changed |
Same. Still not working. For me, it never works until the process is restarted |
In my case, however, the error was on my side because I was using routes nested in directories and subdirectories according to the official Get Started Remix (https://remix.run/docs/en/1.15.0/tutorials/blog), the documentation (https://remix.run/docs/en/1.15.0/guides/routing) and other sources on the internet that I came across. Only later did I realise that the routes directory must look like this is described here: https://remix.run/docs/en/main/file-conventions/route-files-v2. |
Same with me using v1.15.0 and Windows, still can't detect new routes. |
From what I understand, this should be fixed in 1.16.0 |
@machour seems like still unresolved on v1.16: this is despite remix routes picking up the file: |
Can confirm that the same behavior is still happening. When the dev server is running, all route changes (new files, deletions, renames, etc.) are not detected until the dev server is stopped and restarted. |
turns out it is a path issue, but higher up the chain.. |
I'm having this issue on Windows. Was working in 1.14.3, no longer working. Currently using 1.16.0. Update: This works for me in 1.16.0. My issue was that I was using remix.config.ts (as I attempted to switch it to Typescript). The remix config file must be Javascript. |
Just noticed that this is now working in the latest nightly builds! |
woo! i messed up the bot so it didn't post an update here with details, sorry! the version is |
🤖 Hello there, We just published version Thanks! |
@mcansh Can confirm that new routes are now working in windows with v2 routing flag on! |
🤖 Hello there, We just published version Thanks! |
What version of Remix are you using?
v1.11.1
Are all your remix dependencies & dev-dependencies using the same version?
Steps to Reproduce
npx create-remix
and go through all the steps.future: {v2_routeConvention: true,}
toremix.config.js
.npm run dev
app/routes/test.tsx
and a basic export default component.localhost:3000/test
Expected Behavior
See the test route.
Actual Behavior
404 Not Found thrown.
sample repo:
https://github.com/xHomu/remix-v2-routes-new2/blob/main/app/routes/test.tsx
The text was updated successfully, but these errors were encountered: