Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix esbuild browser build external builtinModules of node.js causes import AWS-sdk error #5521

Closed
1 task done
jackyleefu opened this issue Feb 20, 2023 · 4 comments
Closed
1 task done

Comments

@jackyleefu
Copy link

What version of Remix are you using?

v1.13.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

import AWS from "aws-sdk";

aws-sdk dependency buffer and other package for the browser from nodejs buildinModule, Remix esbuild browser make it external causes bundle for browser error

Expected Behavior

no error in browser

Actual Behavior

In Browser
Uncaught Error: Dynamic require of "buffer/" is not supported

@brresnic
Copy link

I'm running into this too

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-bd289fa-20230822 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@markdalgleish
Copy link
Member

I've merged a fix for this that will be going out in our v2 release.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Merged
Development

No branches or pull requests

5 participants