[BUG]: Remix watch command forces NODE_ENV to development

[jaidetree]

What version of Remix are you using?

1.18

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

1. Create a remix app using the express adapter
2. Run NODE_ENV=test remix watch
3. In a remix loader in root.tsx, add console.log(process.env.NODE_ENV)
4. In express, log process.env.NODE_ENV
5. Run the express app with NODE_ENV=test node server.js (or whichever command starts the server)

Hit a remix route and see what gets logged.

Expected Behavior

• Express will print test
• The Remix route will also print test

Actual Behavior

• Express will print test
• The Remix route will print development.

I traced it down and it seems the issue stems from the liveReload server used by the watch command:

1. The watch command calls devServer.liveReload(config);

   remix/packages/remix-dev/cli/commands.ts

   Line 207 in 8268142

   devServer.liveReload(config);

2. Which then calls await watch(...)
3. Which forces the mode\env var

   remix/packages/remix-dev/devServer/liveReload.ts

   Line 48 in 8268142

   mode: "development",

[jaidetree]

I'm open to fix it provided a maintainer\contributor gives me the greenlight to create a PR.

[pcattori]

@jaidetree 🟢

[pcattori]

Fixed by #7117

[jaidetree]

Ack! I knew there was something I forgot to do 😅 Thank you!!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!