UIMatch still has issues

[lifeiscontent]

What version of Remix are you using?

2.0.1

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzsAzgNQIYBtgBMCiWApiEQHbwC+cAZlBCHAERREYDGMTA3AFCiRYiOAFcURALIYY7ABZEUAGjgBVAJJSZsuNToNmAAVYhgADwC0UEWQD0rDlz68a1zsAhlkKTXIDqwGFkAZWAAczIiXDUyCXIRAApeODgbGzg1OAB3DAo4GAhRcVUNaTk8gE8wIjh5VmUAIxF4dhyAchgkuBBS2QAuOAAlIhgRKDIAFUqiAB4YKYgaQskehQA+AG0yERB6oigAXUVeAEp+7q0vYp9ZaesAazIITLJlJBQwiKiYuP6hhwA6P6cQgkchUVaITrARbxOZVBZdHr-WQ5XDEOAAQgAvFjmBB6gArIicJhwAA+ZMRWmRqPRONxWywWGOkOSyVYIzGtGw4j4yUovChMIx8SY73CkWisS2pOAnnOchpZDRRGOLIQnXZw1GnhoPKIfJ0guS0Lg8QxqEwOAIxFIFHiCtkSpV-3FnylcTVrLZHJ13KwvM6As6vq5MCsBt4wZcZDcHjg+FMGHAxHi6s67A8KHgjoUcFxYmWWgUacNqTyslQNQwKDgGAqVTge3oUCy8k8YjloQr1XU1wbRAzWfgbsl3y2tdxuZQ-xowCwMD28VQ138gRCEq+0pExycWs5nkZWD4AqAA

Expected Behavior

be able to use UIMatch from @remix-run/react

Actual Behavior

can't use UIMatch from @remix-run/react due to some type overlap issues

[lensbart]

See also here

[ngbrown]

I will say that having different UIMatch exported from two different packages is confusing.

I have to use import type { UIMatch as UIMatchRR } from "@remix-run/router"; on functions that dealing with the return from useMatches().

I then use import type { UIMatch } from "@remix-run/react"; in the actual routes so I can get the UIMatch<typeof loader> functionality.

I have a file that imports both, thus the as in the import. I think it would be better to have two different type names from the beginning, or just make us do our own SerializeFrom<typeof loader>.

[brophdawg11]

I will say that having different UIMatch exported from two different packages is confusing.

This is a requirement because UIMatch.data is serialized over the network in Remix, but not in RR - so we need the types to reflect that.

[brophdawg11]

@lensbart Thanks for the repro - this looks like a quick fix - we are accidentally exporting the RR version of useMatches from @remix-run/react instead of the Remix wrapper. I'll get a PR up to fix this 👍

[brophdawg11]

This is resolved by #7551 and will be available in the next release

[github-actions]

🤖 Hello there,

We just published version 2.1.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 2.1.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!