Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite build creates build/client/.vite/manifest.json, which gets exposed as static asset #8589

Closed
nramovs-sr opened this issue Jan 24, 2024 · 1 comment

Comments

@nramovs-sr
Copy link

Reproduction

https://remix.run/.vite/manifest.json

System Info

System:
    OS: macOS 14.3
    CPU: (10) arm64 Apple M1 Max
    Memory: 156.59 MB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 3.7.0 - ~/.nvm/versions/node/v20.10.0/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
    bun: 1.0.3 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: 120.1.61.120
    Chrome: 121.0.6167.85
    Chrome Canary: 122.0.6261.3
    Safari: 17.3
  npmPackages:
    @remix-run/dev: ^2.5.1 => 2.5.1 
    @remix-run/eslint-config: ^2.5.1 => 2.5.1 
    @remix-run/express: ^2.5.1 => 2.5.1 
    @remix-run/node: ^2.5.1 => 2.5.1 
    @remix-run/react: ^2.5.1 => 2.5.1 
    @remix-run/testing: ^2.5.1 => 2.5.1 
    vite: ^5.0.12 => 5.0.12

Used Package Manager

yarn

Expected Behavior

Manifest should not be exposed in the client's public folder.

Actual Behavior

build/client/.vite/manifest.json gets created, and is exposed to the internet along with other client assets through app.use(express.static("build/client", { maxAge: "1h" })); (from vite express template). This file contains information about source file structure.

@pcattori
Copy link
Contributor

pcattori commented Feb 1, 2024

Fixed by #8599

@pcattori pcattori closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants