From 79073c8082f47a97dee652a79d58462b6c24be73 Mon Sep 17 00:00:00 2001 From: Remko Popma Date: Fri, 3 May 2019 23:26:22 +0900 Subject: [PATCH] #648 added comment on some trade-offs and TBD items if we want to support capturing multi-char values in char[] types for non-interactive options --- src/main/java/picocli/CommandLine.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/main/java/picocli/CommandLine.java b/src/main/java/picocli/CommandLine.java index c204b430b..e382fe192 100644 --- a/src/main/java/picocli/CommandLine.java +++ b/src/main/java/picocli/CommandLine.java @@ -10739,6 +10739,10 @@ private Collection createCollection(Class collectionClass, Class e } private ITypeConverter getTypeConverter(final Class type, ArgSpec argSpec, int index) { if (argSpec.converters().length > index) { return argSpec.converters()[index]; } + // https://github.com/remkop/picocli/pull/648 + // consider adding ParserSpec.charArraysCanCaptureStrings() to allow non-interactive options to capture multi-char values in a char[] array + // Note that this will require special logic for char[] types in CommandLine$Interpreter.applyValuesToArrayField; + // TBD: what to do with multiple values? Append or overwrite? if (char[].class.equals(argSpec.type()) && argSpec.interactive()) { return converterRegistry.get(char[].class); } if (converterRegistry.containsKey(type)) { return converterRegistry.get(type); } if (type.isEnum()) {