Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load: Add ability to specify custom config file (reboot). fixes #755 #855

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

knksmith57
Copy link
Contributor

@knksmith57 knksmith57 commented Jun 14, 2016

Per original PR / conversation by @kentcdodds & @remy in #755, this implements
the --config <file> option allowing users to load an arbitrary config file
instead of being bound to the default $PWD/nodemon.json.

Patch includes:

  • --config option parsing
  • Documentation updates
  • light (maybe sufficient?) unit test coverage

@knksmith57
Copy link
Contributor Author

tests pass but it looks like my commit message violates the rules for this repo; I'mma try and figure out where those are documented (not familiar with this ci/semantic-release witchcraft)

@knksmith57
Copy link
Contributor Author

Implement `--config <file>` option to allow config loading from an arbitrary file instead of being
bound to the static `$PWD/nodemon.json`.
@knksmith57
Copy link
Contributor Author

cool, looks like that passes now. commit message guidelines are a beautiful thing 😃

@LoicMahieu
Copy link

Really interested in this feature!
In fact I wish nodemon looks recursively for nodemon.json in parent folders but at least a --config should do the job! ;)

@knksmith57
Copy link
Contributor Author

@remy when you have a chance, would love some feedback on this one

@knksmith57
Copy link
Contributor Author

heya @remy, any chance we can get a code review on this one when you have a chance?

@remy remy merged commit ee110ad into remy:master Jul 25, 2016
@knksmith57
Copy link
Contributor Author

thanks sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants