Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Launcher self-update doesn't work #170

Closed
remyroy opened this issue May 10, 2018 · 10 comments
Closed

Launcher self-update doesn't work #170

remyroy opened this issue May 10, 2018 · 10 comments

Comments

@remyroy
Copy link
Owner

remyroy commented May 10, 2018

It seems like the launcher self-update process doesn't work. This needs some investigation.

@ZhilkinSerg
Copy link
Contributor

Confirming.

@Beetlecat
Copy link

Shoot -- me as well. Any issues with just dropping the new one right over the top of the old? ❔

@remyroy
Copy link
Owner Author

remyroy commented May 20, 2018

Just replacing the old with the new one should work just fine.

@remyroy
Copy link
Owner Author

remyroy commented Oct 15, 2018

I'll be working on replacing the old single file distribution with a proper installer and update process. This will require time and effort so patience is required for this to be fixed properly.

@Mister-Cultist
Copy link

It's happening for me as well, so we just wait for the update to fix it?

@D3L33T3D
Copy link

Anyone news on a fix to the update launcher? I have zero programming skills but I love the game and any news on a fix would be great. Thanks for such a fun game btw.

@evankimori
Copy link

evankimori commented May 2, 2019

(Launcher version 1.3.19)

In this new build: is the Launcher meant to operate with confirmation popup of removal of 'previous_version' folder and more user input to send to Recycle Bin specific folders?

Escalating it to Admin Run doesn't seem to make the popups go away.

Also: the confirmation popups tend to always migrate to my secondary monitor and hide behind other windows so when using the Update button: the operation is stuck at 'Deleting previous_version directory' until I find the offending popup and remove it.

First time I've ever seen the launcher ask me for a confirmation to add/remove/update folders. I can supply screenshots and log files if directed where necessary.

launcher error

@remyroy
Copy link
Owner Author

remyroy commented May 2, 2019

@evankimori This is unrelated to the current issue. This should probably be in a new issue.

Recent versions of the launcher uses the FileOperation API to send elements in the recycle bin instead of deleting them. There is no confirmation prompt on Windows 10. Maybe Windows 7 shows one or maybe this is under some circumstances only. I can't control the location of the prompt windows since this is within a Windows API.

There are various flags that can be used with this API. A combination of FOF_WANTNUKEWARNING and FOF_NOCONFIRMATION might do the trick to prevent this prompt while keeping the safeguard of a prompt if a file cannot be sent to the recycle bin and it needs to be confirmed by the user.

@evankimori
Copy link

@remyroy Thank you for the update and info, my bad in posting it here. I'll create another issue with this problem separately. :)

@remyroy
Copy link
Owner Author

remyroy commented Jun 2, 2019

This will be fixed starting with version 1.4 meaning that if you have version 1.4, you can have the launcher self-update to later versions.

@remyroy remyroy closed this as completed Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants