Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variable to skip getting labels from docker hub #29624

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

raphaelzoellner
Copy link
Contributor

Changes

A self-hosted experimental environment variable RENOVATE_X_DISABLE_DOCKER_HUB_LABELS which disables label requests to https://index.docker.io/.

Context

This implements the proposed option from #29582.

This aims to optionally reduce the impact on the DockerHub rate limit further in scenarios where labels are not required (e.g. dry-run lookups).

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice June 12, 2024 17:24
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins I would like to defer until the recent refactor of flags has landed.

docs/usage/self-hosted-experimental.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-experimental.md Show resolved Hide resolved
@rarkins rarkins enabled auto-merge June 28, 2024 07:54
@rarkins rarkins added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@rarkins rarkins added this pull request to the merge queue Jun 28, 2024
Merged via the queue into renovatebot:main with commit 5092366 Jun 28, 2024
35 checks passed
@viceice viceice mentioned this pull request Jun 28, 2024
6 tasks
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.421.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants