Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Revert "build(deps): update dependency re2 to v1.21.1" #29644

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 13, 2024

Reverts #29634

1.21.1 still had memory problems
1.21.2 fails our tests

@rarkins rarkins enabled auto-merge June 13, 2024 05:47
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the memory issues so big? is my user complaining?

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 13, 2024

This has not been published long enough for any users to use it and complain. Needs reverting immediately before that happens

@rarkins rarkins requested a review from viceice June 13, 2024 06:32
@viceice
Copy link
Member

viceice commented Jun 13, 2024

uhop/node-re2#212

@rarkins rarkins added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 62a3c7c Jun 13, 2024
37 checks passed
@rarkins rarkins deleted the revert-29634-renovate/re2-1.x branch June 13, 2024 07:57
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.407.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants