Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vulnerabilities): strip equals for nuget in Github alerts #29693

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Jun 15, 2024

Changes

While testing a solution for #29600, I found that GitHub vuln alerts for nuget don't raise security fix PRs. This change strips = analogous to what was done before for maven and go, so that package rules become applicable to nuget deps.

The underlying issue is that GitHub prefixes the version in the vulnerableRequirements field with =, e.g., vulnerableRequirements": "= 2.0.0", eventually leading to package rules that include "matchCurrentVersion": "= 2.0.0". The beginning = causes the rule never to match, resulting in no security fix PRs.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: https://github.com/renovate-demo/29600-github-vuln-alerts-nuget/pulls

@Churro Churro changed the title fix(vulnerabilities): strip equals for nuget fix(vulnerabilities): strip equals for nuget in Github alerts Jun 15, 2024
@rarkins rarkins added this pull request to the merge queue Jun 16, 2024
Merged via the queue into renovatebot:main with commit 32c9636 Jun 16, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.408.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants