-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): Remove usePlatformAutomerge restriction with gitLabIgnoreApprovals #29972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs test addition for new case
@rarkins Sorry about that. New test added. |
Had to push again to fix prettier. Hooks weren't working locally in my dev container. |
🎉 This issue has been resolved in version 37.421.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Remove
usePlatformAutomerge
restriction withgitLabIgnoreApprovals
.Context
Discussed in #29968.
I took a non-invasive approach minimize any impact elsewhere by users.
gitLabIgnoreApprovals
to bypass approver restrictions on GitLab to auto-merge MRs that pass our pipeline.automergeSchedule
to enforce this during business hours.automergeSchedule
ifplatformAutomerge=true
, so we makeplatformAutomerge=false
gitLabIgnoreApprovals
anymore since it's gated behindplatformAutomerge=true
We remove this check since it doesn't look like it's necessary.
Original PR with this addition even includes a comment wondering if it can be used with normal auto-merge.
https://github.com/renovatebot/renovate/pull/10981/files#r679454321
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: