-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): check for undesirable test additions #31852
Conversation
Example of added snapshots: https://github.com/renovatebot/renovate/actions/runs/11232716644/job/31224874499?pr=31852 Example of added fixtures: https://github.com/renovatebot/renovate/actions/runs/11232744890/job/31224958602?pr=31852 |
It would be good if we could add a development docs page for these and link to them with longer explanation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
🎉 This PR is included in version 38.118.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
echo "Updated total number of deleted files in '__fixtures__': $NUM_DELETED_FIXTURES" | ||
|
||
if [ "$NUM_ADDED_FIXTURES" -gt "$NUM_DELETED_FIXTURES" ]; then | ||
echo "❌ Error: More files have been added to '__fixtures__' directories than deleted." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What am I supposed to do instead?
The tool I am working with cannot generate reproducible lock files offline and my testing is otherwise pretty much useless.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: