Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): check for undesirable test additions #31852

Merged
merged 14 commits into from
Oct 11, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 8, 2024

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title Create undesirable-test-additions.yaml chore(tests): check for undesirable test additions Oct 8, 2024
@rarkins
Copy link
Collaborator Author

rarkins commented Oct 8, 2024

@rarkins
Copy link
Collaborator Author

rarkins commented Oct 8, 2024

It would be good if we could add a development docs page for these and link to them with longer explanation

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@rarkins rarkins requested a review from viceice October 11, 2024 08:05
@rarkins rarkins added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 3000b79 Oct 11, 2024
39 checks passed
@rarkins rarkins deleted the test/undesirable-test-additions branch October 11, 2024 08:38
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.118.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

echo "Updated total number of deleted files in '__fixtures__': $NUM_DELETED_FIXTURES"

if [ "$NUM_ADDED_FIXTURES" -gt "$NUM_DELETED_FIXTURES" ]; then
echo "❌ Error: More files have been added to '__fixtures__' directories than deleted."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What am I supposed to do instead?

The tool I am working with cannot generate reproducible lock files offline and my testing is otherwise pretty much useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants