Docker datasource fails with quay.io image

[ChipWolf]

Which Renovate are you using?

WhiteSource Renovate App

Which platform are you using?

GitHub.com

Have you checked the logs? Don't forget to include them if relevant

#173578276

{
  "registry": "https://quay.io",
  "dockerRepository": "helmpack/chart-testing",
  "err": {
    "name": "HTTPError",
    "host": "quay.io",
    "hostname": "quay.io",
    "method": "GET",
    "path": "/v2/helmpack/chart-testing/blobs/sha256:9bd606e7cb0450e6d7e1cd2152a48298cf6e0d78417d79a32e948bcca8e7dd15",
    "protocol": "https:",
    "url": "https://quay.io/v2/helmpack/chart-testing/blobs/sha256:9bd606e7cb0450e6d7e1cd2152a48298cf6e0d78417d79a32e948bcca8e7dd15",
    "gotOptions": {
      "path": "/v2/helmpack/chart-testing/blobs/sha256:9bd606e7cb0450e6d7e1cd2152a48298cf6e0d78417d79a32e948bcca8e7dd15",
      "protocol": "https:",
      "slashes": true,
      "auth": null,
      "host": "quay.io",
      "port": null,
      "hostname": "quay.io",
      "hash": null,
      "search": null,
      "query": null,
      "pathname": "/v2/helmpack/chart-testing/blobs/sha256:9bd606e7cb0450e6d7e1cd2152a48298cf6e0d78417d79a32e948bcca8e7dd15",
      "href": "https://quay.io/v2/helmpack/chart-testing/blobs/sha256:9bd606e7cb0450e6d7e1cd2152a48298cf6e0d78417d79a32e948bcca8e7dd15",
      "headers": {
        "user-agent": "Renovate Bot (GitHub App 2740)",
        "authorization": "** redacted **",
        "accept-encoding": "gzip, deflate"
      },
      "hooks": {
        "beforeError": [],
        "init": [],
        "beforeRequest": [],
        "beforeRedirect": [
          null
        ],
        "beforeRetry": [],
        "afterResponse": []
      },
      "retry": {
        "methods": {},
        "statusCodes": {},
        "errorCodes": {}
      },
      "decompress": true,
      "throwHttpErrors": true,
      "followRedirect": true,
      "stream": false,
      "form": false,
      "json": false,
      "cache": false,
      "useElectronNet": false,
      "method": "GET",
      "hostType": "docker"
    },
    "statusCode": 400,
    "statusMessage": "Bad Request",
    "headers": {
      "x-amz-request-id": "6A0<snip>7004",
      "x-amz-id-2": "cFmc8KCUsl<snip>kr30=",
      "content-type": "application/xml",
      "transfer-encoding": "chunked",
      "date": "Wed, 06 May 2020 15:26:50 GMT",
      "connection": "close",
      "server": "AmazonS3"
    },
    "body": "\nInvalidArgumentOnly one auth mechanism allowed; only the X-Amz-Algorithm query parameter, Signature query string parameter or the Authorization header should be specifiedAuthorizationBearer eyJhbGciO<snip>2SiIdKSkr30=",
    "message": "Response code 400 (Bad Request)",
    "stack": "HTTPError: Response code 400 (Bad Request)\n    at EventEmitter. (/home/ubuntu/renovateapp/node_modules/got/source/as-promise.js:74:19)\n    at runMicrotasks ()\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)"
  }
}

What would you like to do?

I would like Renovate to find updates for Docker images hosted at quay.io, a popular Docker image registry.

[rarkins]

Need to work out why the existing logic

renovate/lib/util/http/index.ts

Lines 53 to 64 in d54836b

	if (opts.search?.includes('X-Amz-Algorithm')) {
	// if there is no port in the redirect URL string, then delete it from the redirect options.
	// This can be evaluated for removal after upgrading to Got v10
	const portInUrl = opts.href.split('/')[2].split(':')[1];
	if (!portInUrl) {
	// eslint-disable-next-line no-param-reassign
	delete opts.port; // Redirect will instead use 80 or 443 for HTTP or HTTPS respectively
	}
	// registry is hosted on amazon, redirect url includes authentication.
	delete opts.headers.authorization; // eslint-disable-line no-param-reassign
	delete opts.auth; // eslint-disable-line no-param-reassign

isn't working. Note: it wasn't created specifically for quay.io, but seems generic.

[rarkins]

Probably requires a code change, but let's reproduce and debug it first to be sure.

[ChipWolf]

Reproduced here https://github.com/ChipWolf/renovate-637

#173979741

DEBUG: Unauthorized docker lookup

[ChipWolf]

Still an issue, should this be moved over to the main repo @rarkins?

[ChipWolf]

Duplicate of #4626