ECR repository behind friendly URL throws errors

[jonathanmorley]

This is the same as #3800, but with the addition of friendly URLs in front of ECR.

Proposal

Add a config value to be able to manually drop the docker limits value from

renovate/lib/datasource/docker/index.js

Line 276 in 6de255e

const limit = ecrRegex.test(registry) ? 1000 : 10000;

[rarkins]

Alternatively is there anything in the headers that are returned from the rejection that we can detect/parse and retry with 1000 instead of 10000 ?

[viceice]

@jonathanmorley Do you know any public ecr docker repo we can test against ?

[viceice]

Idea: check for amazon headers in getAuthHeaders, eg: x-amzn-requestid and return reduced tags limit

[jonathanmorley]

I don't know of any public ECR docker repo we could use for this, but I can say that our proxy that fronts ECR does not respond with any headers identifying it as fronting AWS or the limit it supports

[jonathanmorley]

We could recognise the specific error message that ECR throws:

{"errors":[{"code":"UNSUPPORTED","message":"Invalid parameter at 'maxResults' failed to satisfy constraint: 'Member must have value less than or equal to 1000'"}]}

Headers:

HTTP/1.1 405 Method Not Allowed
Content-Type: application/json; charset=utf-8
Date: Wed, 27 Jan 2021 21:46:48 GMT
Docker-Distribution-Api-Version: registry/2.0
Content-Length: 164
Connection: keep-alive

And handle it by dropping the limit down

[HonkingGoose]

There's a typo in the PR title:

Change reopsitory -> repository

[rarkins]

Related: #11322 (might be the solution for this issue)

[michaelheyman]

We are also blocked from using the docker datasource because of this issue.

The related issue suggests that this is a policy issue, which is not the case for us.

Ideally, like this issue suggests, we would be able to somehow configure which ecrRegex where the tag list replacement is being done, or check against the 405 and maybe the Docker-Distribution-Api-Version header before retrying with a <=1000 value.

Looking forward to updates on this.

[rarkins]

PRs welcome. It needs someone using this setup of ECR to fix and verify it.

[renovate-release]

🎉 This issue has been resolved in version 31.45.0 🎉

The release is available on:

• GitHub release
• 31.45.0

Your semantic-release bot 📦🚀