Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tombstone data should not be returned by default in high-level dataframe APIs #7493

Closed
teh-cmc opened this issue Sep 24, 2024 · 2 comments · Fixed by #7652
Closed

Tombstone data should not be returned by default in high-level dataframe APIs #7493

teh-cmc opened this issue Sep 24, 2024 · 2 comments · Fixed by #7652
Assignees
Labels
🧑‍💻 dev experience developer experience (excluding CI) feat-dataframe-view Everything related to the dataframe view 🔍 re_query affects re_query itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 24, 2024

Their semantics always apply no matter what -- a tombstone is a tombstone -- but users don't want to look at the tombstone themselves in 99% cases.

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 🔍 re_query affects re_query itself feat-dataframe-view Everything related to the dataframe view labels Sep 24, 2024
@teh-cmc teh-cmc self-assigned this Sep 24, 2024
@abey79
Copy link
Member

abey79 commented Sep 24, 2024

Yes.

In terms of Jeremy's new proposal, to me it make sense to see the tombstone in the "raw" data (e.g. where each row corresponds to a log event), because at this point, the tombstone semantic is not yet applied. But as soon as it is applied, it should no longer be visible.

@jleibs
Copy link
Member

jleibs commented Oct 4, 2024

I realized we didn't specify what to do with tombstones as part of https://www.notion.so/rerunio/Repeated-Time-Values-10bb24554b1980d8a0cdcca3d8903502

I agree generally hiding them from the view makes sense for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) feat-dataframe-view Everything related to the dataframe view 🔍 re_query affects re_query itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants