Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate genType docs into main docs as "TypeScript interop" #746

Closed
fhammerschmidt opened this issue Nov 13, 2023 · 2 comments · Fixed by #755
Closed

Integrate genType docs into main docs as "TypeScript interop" #746

fhammerschmidt opened this issue Nov 13, 2023 · 2 comments · Fixed by #755
Milestone

Comments

@fhammerschmidt
Copy link
Member

genType has moved into the compiler since 10.1 and flow support has been dropped

Let's move its docs into the main section as "TypeScript interop". Remove all mentions of "flowtype" and "Reason" and update the docs.

@cometkim
Copy link
Member

IMHO TypeScript interop shouldn't be treated as special. Except for gentype-specific config, most of it is required for general JS codebase interoperability. Instead, we can say that TypeScript is supported natively.

Instead of the "TypeScript interop" chapter, I suggest providing more generally useful guides in a "Working with JavaScript/TypeScript projects" chapter.

For example, https://rescript-collection.pages.dev/docs/javascript#pipe-operator describes how dealing with pipe patterns in JS codebase.

@fhammerschmidt
Copy link
Member Author

fhammerschmidt commented Dec 18, 2023

Moving those issues over from #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants