Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging & Metrics #3

Closed
dfarr opened this issue Aug 23, 2023 · 1 comment · Fixed by #5
Closed

Logging & Metrics #3

dfarr opened this issue Aug 23, 2023 · 1 comment · Fixed by #5
Assignees
@dfarr

Comments

@dfarr
Copy link
Member

dfarr commented Aug 23, 2023

Logging

Structured logs - slog - are now a part of the go standard library. Let's use this over third party options (eg. zap).

Metrics

Let's use prometheus for metrics and prefer cross cutting metrics wherever possible. Initially let's implement counters, specifically:

  • IO Operations
    • type
    • total/success/failure
  • Coroutines
    • total
    • in progress
  • API
    • type (http/grpc)
    • total/success/failure (500s + 429)
@dfarr dfarr self-assigned this Aug 23, 2023
@dtornow
Copy link
Contributor

dtornow commented Aug 23, 2023

Let's add a docs/metrics.md document detailing the metrics and their dimensions as we add them

@dfarr dfarr mentioned this issue Aug 25, 2023
Merged
@dfarr dfarr closed this as completed in #5 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfarr dfarr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Logging and Metrics resonatehq/resonate
2 participants
@dtornow @dfarr