Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shuffle to use tailing iterator for performance improvements #1641

Open
tillrohrmann opened this issue Jun 19, 2024 · 1 comment
Open

Comments

@tillrohrmann
Copy link
Contributor

With the fix for #1639, we are now issuing a RocksDB scan operation for every outbox read by the shuffle. This is highly inefficient and should rather use a tailing iterator similar to how the LocalLogletReadStream is implemented.

@pcholakov
Copy link
Contributor

From @tillrohrmann:

With the global total order log the shuffle will probably go away and improving it might not be worth it at this point.

Let's not pick this until it's clear that this optimisation is needed long-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants