Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outguess leaves a signature in file headers after embedding information #4

Open
hoijui opened this issue Apr 14, 2020 · 2 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@hoijui
Copy link
Collaborator

hoijui commented Apr 14, 2020

as mentioned here (in an other fork of outguess): crorvick/outguess#1

(NOTE: I did not try if it happens with this outguess too, but I would assume it does)

Outguess doesn't preserve the image header, and if you do hexdump {image}.jpg | grep CDEF you'll see what I mean

@hoijui hoijui added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed and removed enhancement New feature or request labels Apr 28, 2020
@sandsmark
Copy link

sandsmark commented Oct 4, 2020

This looks bogus, outguess just uses a standard copy of libjpeg with a twoline patch that only touches the coefficients calculation, and more or less the example code for writing the jpeg.

The same "signature" is in the libjpeg sample jpegs, even in libjpeg-turbo:
image

outguess could be improved by using jpeg_read_coefficients() and jpeg_write_coefficients(), though, then it doesn't need to ship a patched copy of libjpeg, improves performance, doesn't need to recompress etc. and can generate an otherwise identical file

@eribertomota
Copy link
Collaborator

@sandsmark it is very good idea. Now OutGuess structure is re-organized (after several commits). Do you have time to implement your idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants