Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should probably fail if an include regex does not match #10

Open
keith-turner opened this issue Apr 9, 2015 · 2 comments
Open

Should probably fail if an include regex does not match #10

keith-turner opened this issue Apr 9, 2015 · 2 comments

Comments

@keith-turner
Copy link
Member

If a an include regex does not match any types, it indicates a problem and the APILyzer should probably fail in this case. I ran into a case where I specified multiple include regexs and one of them matched nothing when I expected it to match something.

@ctubbsii
Copy link
Member

ctubbsii commented Apr 9, 2015

We could probably print out a warning if an include rule is completely unused. Maybe later, add an option to fail instead. This won't catch everything... there may be redundant rules which are both used, but because of short-circuiting, we didn't notice that one was unneeded.

@keith-turner
Copy link
Member Author

The situation I ran into that prompted me open this issue was :

  • forgot to add dependency on accumulo-minicluster to pom
  • added a rule to include some types from accumulo-minicluster

@ctubbsii ctubbsii added this to the 1.1.0 milestone Apr 10, 2015
@ctubbsii ctubbsii modified the milestones: 1.1.0, 1.2.0 Oct 5, 2017
@ctubbsii ctubbsii removed this from the 1.2.0 milestone Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants