Error when building esy-skia on MacOS

[erodactyl]

I went through the steps of installing the quick-start, but it fails at the build stage. I am on MacOS Big Sur and using esy 0.6.11. The same error happens when trying to build the Onivim2 editor.

esy_libjpeg_turbo-dc3b4679/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/ports/SkFontHost_mac.cpp -o obj/src/ports/libskia.SkFontHost_mac.o
    ../../src/ports/SkFontHost_mac.cpp:1721:29: error: multi-character character constant [-Werror,-Wfour-char-constants]
        if (!this->getTableSize('glyf') || !this->getTableSize('loca')) {
                                ^
    ../../src/ports/SkFontHost_mac.cpp:1721:60: error: multi-character character constant [-Werror,-Wfour-char-constants]
        if (!this->getTableSize('glyf') || !this->getTableSize('loca')) {
                                                               ^
    2 errors generated.
    [210/1196] compile ../../third_party/externals/libpng/pngget.c
    [211/1196] compile ../../third_party/externals/icu/source/common/ulistformatter.cpp
    [212/1196] compile ../../third_party/externals/icu/source/common/uiter.cpp
    [213/1196] compile ../../third_party/externals/libpng/pngpread.c
    [214/1196] compile ../../third_party/externals/icu/source/common/uloc_keytype.cpp
    [215/1196] compile ../../third_party/externals/libpng/png.c
    [216/1196] compile ../../third_party/externals/libpng/pngread.c
    [217/1196] compile ../../third_party/externals/icu/source/common/ucnvmbcs.cpp
    [218/1196] compile ../../third_party/externals/icu/source/common/uloc.cpp
    ninja: build stopped: subcommand failed.
    error: command failed: 'bash' './esy/build.sh' 'darwin' '/Users/erikdavtyan/.esy/3____________________________________________________________/i/esy_libjpeg_turbo-dc3b4679' (exited with 1)
    esy-build-package: exiting with errors above...

  building esy-skia@github:revery-ui/esy-skia#91c98f6
esy: exiting due to errors above

[glennsl]

Looks like a new version of clang adding new warnings that need to be disabled here for it to compile again: https://github.com/revery-ui/esy-skia/blob/master/gn/BUILD.gn#L375-L392

Then you can just add a resolution in package.json to override the esy-skia version that revery currently uses.

[glennsl]

I've merged a fix to esy-skia. Adding this to package.json should be sufficient:

  "resolutions": {
    "esy-skia": "revery-ui/esy-skia#b8aff12"
  }

A proper fix would be to have revery reference this fix, and then update this to use the latest revery , but unfortunately that has some other issues.