Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Not forwarding correct Content-Type header. #359

Closed
itzTheMeow opened this issue Jan 25, 2023 · 3 comments
Closed

bug: Not forwarding correct Content-Type header. #359

itzTheMeow opened this issue Jan 25, 2023 · 3 comments
Labels
bug Something isn't working crate:services:january crates/services/january good first issue Good for newcomers help wanted Extra attention is needed

Comments

@itzTheMeow
Copy link

What happened?

When proxying SVGs (for example) the output content-type is text/plain which causes them to fail to render in the browser.

Example:

Github Favicon: https://github.githubassets.com/favicons/favicon.svg
image

Proxy: https://jan.revolt.chat/proxy?url=https%3A%2F%2Fgithub.githubassets.com%2Ffavicons%2Ffavicon.svg
image

image does not load in <img> tag
image

(if i manually input the github URL instead of proxy)
image
@itzTheMeow itzTheMeow added the bug Something isn't working label Jan 25, 2023
@LawsOfScience
Copy link

This seems like a pretty quick fix, I'll take a look at it

@LawsOfScience LawsOfScience mentioned this issue Sep 22, 2023
Closed
3 tasks
@amycatgirl
Copy link
Contributor

Seems like the PR is stale, can I pick this issue up?

@LawsOfScience
Copy link

Seems like the PR is stale, can I pick this issue up?

Should be a fairly simple fix. Go for it!

@insertish insertish added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 28, 2024
@insertish insertish transferred this issue from revoltchat/january Sep 29, 2024
@insertish insertish added the crate:services:january crates/services/january label Sep 29, 2024
@github-project-automation github-project-automation bot moved this from 💡 Open to ✅ Done in Revolt Project Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working crate:services:january crates/services/january good first issue Good for newcomers help wanted Extra attention is needed
Projects
Revolt Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Proxy MIME type in Content-Type header LawsOfScience/january
4 participants
@LawsOfScience @insertish @itzTheMeow @amycatgirl