From eb11c61e7bc14553e3256acafdb4d0096df18c27 Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Tue, 19 Jul 2016 13:35:11 -0700 Subject: [PATCH] Remove an extra \r\n and fix a test. The multipart tests hadn't been updated to expect the content-transfer-encoding header. Closes #40 R=rnystrom@google.com Review URL: https://codereview.chromium.org//2152793003 . --- CHANGELOG.md | 4 ++-- lib/src/multipart_request.dart | 2 +- pubspec.yaml | 2 +- test/multipart_test.dart | 1 - 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b149a296ae8ff..bb02985362c49 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ -## 0.11.4-dev +## 0.11.3+9 -* Fix an error in multipart_test. +* Remove an extra newline in multipart chunks. ## 0.11.3+8 diff --git a/lib/src/multipart_request.dart b/lib/src/multipart_request.dart index 9e145c72f2391..2d3b318c9d0c9 100644 --- a/lib/src/multipart_request.dart +++ b/lib/src/multipart_request.dart @@ -135,7 +135,7 @@ class MultipartRequest extends BaseRequest { if (!isPlainAscii(value)) { header = '$header\r\n' 'content-type: text/plain; charset=utf-8\r\n' - 'content-transfer-encoding: binary\r\n'; + 'content-transfer-encoding: binary'; } return '$header\r\n\r\n'; } diff --git a/pubspec.yaml b/pubspec.yaml index 6a42c7a9d9cf3..4aa69c1b06112 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: http -version: 0.11.4-dev +version: 0.11.3+9 author: "Dart Team " homepage: https://github.com/dart-lang/http description: A composable, Future-based API for making HTTP requests. diff --git a/test/multipart_test.dart b/test/multipart_test.dart index 2a61430c4e29d..8f908f938bff9 100644 --- a/test/multipart_test.dart +++ b/test/multipart_test.dart @@ -98,7 +98,6 @@ void main() { content-type: text/plain; charset=utf-8 content-transfer-encoding: binary - vⱥlūe --{{boundary}}-- '''));