-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playlists not working #61
Comments
Update: after reading other issues, i tried installing from msm and it worked first try. However, it doesnt play anything without the "from emby" at the end. |
Hello @ghostbuster84, Thanks for creating this issue! I need to update the official mycroft skills repo and then you won't have to install from MSM. let me add an issue for that if I don't have one already. Now back to your specific issue, are you having similar problems as noted here: #40 I wasn't able to replicate this issue on my end. Can you provide additional data like the logs you are seeing? That may help us track down what isn't working. |
Here are the logs. I tried without the "from emby", then with it, and once again without. The 2 without the "from emby" did not work. |
It looks like the top one is the call without the 'from' Emby. But I can't see the 'utterance' in the logs for that one to be sure. Both calls are working as I would expect. The lines you see that look like: It does look like in both cases the same songs were chosen and sent to the audio layer. I should have some time to run additional tests in this area. What is the source format of the song? I'm wondering if transcoding is causing some issues here. Just very strange that it works when you add the 'from' emby. The code path for finding/playing the song is the same regardless of if 'from' emby is added or not. |
The song format is mp3 at 48000 sample rate and 128 kbps bit rate. |
What are you running mycroft on, The Mark 1 or on a linux laptop? I do most of my testing/development with mycroft running on my linux laptop. I do have a Mark 1 as well, I"ll try to test that in the next few days to see if I can replicate this issue. |
I use it on Linux desktop and on raspberry pi 3 |
I'm having what seems to be the same issues ghostbuster84 describes -- I am unable to play anything without the "from emby" tag, and cannot play playlists at all. I did try uninstalling and re-installing using mycroft-msm, but there was no change. From my skills.log file using utterance "Hey Mycroft, play under pressure": 2022-01-29 23:11:22.896 | INFO | 18936 | TimerSkill | stopping repeating event to check for timer expiration Here's the skills.log output when using the utterance "Hey Mycroft, play under pressure from emby" To my completely untrained eye, it looks like in the first example, the Playback Control Skill is giving up before EMBY returns results -- perhaps before it's even called -- whereas in the second, the Plaback Control Skill is completely bypassed. Is this an EMBY Skill issue, or a Playback Control Skill issue -- or something else? |
Just a follow up after a little bit of playing around... I tweaked the query timeout in in the Playback control skill and have had some success -- I can now say "play pentatonix" and it will play. In the mycroft-playback-control.mycroftai/init.py file, around line 199: if message.data["searching"]: However, if I add "album," "artist" to the query I still get nothing unless I add "from emby" -- I still can't play a playlist no matter what I try. Please let me know if any of this is helpful or not -- I don't want to give you information you already have, or that is not useful. I have this functionality working as much as I need it to work, and know how to fix it if an update overwrites my tweak. |
This is great information! This was my next area of investigation, just havn't had the time to as of late. Let me dig into the mycroft docs and maybe there is a way this can be configured at the skill level. If that is an option we could add a config option that would allow uses to specify the timeout based on their network/emby hardware. |
Glad it's helpful. I bumped it up to 15 seconds because some queries were still returning after picroft gave up. Occasionally (usually after I haven't played anything through Mycroft for a day or so), the "I don't know how to play that" announcement comes back within a second or two -- but asking again resolves that. I haven't found anything that will make it play from a playlist configured in emby. I'm happy to do some testing if that would be useful. Bill |
@blissb, For the playlist issue did you try using the dedicated intent |
@rickyphewitt 2022-02-20 21:31:38.233 | INFO | 9612 | Emby | {'media': 'playlist stuff', 'utterance': 'play playlist stuff from emby', 'utterances': ['play playlist stuff from emby']} I have confirmed the playlist called "stuff" is on my Emby server. In case it matters: I'm using Emby server 4.6.7.0 on windows 10. Everything else (artist, album, genre) is working, and doesn't need "from emby". It's just play lists that have a problem. I've tried it both with and without the word "playlist" I just tried it from the cli client with "play playlist stuff from emby" -- here's what was returned. 21:48:16.329 | ERROR | 9612 | mycroft.skills.intent_service:handle_converse_error:193 | emby.rickyphewitt: skill id does not exist edit: I just tried the same request in the cli (play playlist stuff from emby") and it did NOT return an error. It still did not play, but that "skill id does not exist" message did not show up. BTW - thanks for all your time and effort on this. I use mycroft to play music almost every day now. |
Whenever I try to play a playlist by saying "hey mycroft, play playlist country music from emby" it returns saying "unable to find or play playlist country music".
The text was updated successfully, but these errors were encountered: