Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create on/off toggle for Google Docs #220

Open
4 of 7 tasks
adonahue opened this issue Oct 29, 2019 · 5 comments
Open
4 of 7 tasks

Create on/off toggle for Google Docs #220

adonahue opened this issue Oct 29, 2019 · 5 comments
Assignees
Milestone

Comments

@adonahue
Copy link

adonahue commented Oct 29, 2019

This story was incorporated into #235. There is no separate PR for this card. Keeping this card for QA purposes.
++++++++++++++++++++++++++++++++++++++++++++++++++++

As a GT user, I would like to be able to turn the google doc "whiteboard" off or on, so that I can use Riff to best accommodate the needs of my particular meeting.

As a PM, I would like the Google doc to be on by default, so that users know it's a feature, and do not have to find it and turn it on to use it.

** Acceptance Criteria **

  • Add two new document icons (in comments below) between the mic and screen share options, so that the user has a control to open and close the doc.
  • When the document is closed, the vertical video tile strip should expand (tile) to use the full width of the screen as it does in a regular Riff Video display, so that users can see each other better.
  • When a document is opened, the tiles should revert back to the vertical display.
  • Have the document open as the default behavior when a user joins a room, so that the feature is evident to the user.

*** With screen sharing ***

  • Enable screen sharing in the GT build if it is not already.
  • When someone in the meeting screen shares, close the google doc (if displayed) for all users, so that the document real estate can be used for the screen sharing display. Keep users vertically tiled.
  • When screen sharing is ended, the google doc should return to the state it was in (either open or closed) for each user.
@adonahue adonahue added the sprint candidate Please review before Planning meeting label Oct 30, 2019
@jaedoucette
Copy link

We think that, in the event google docs cannot be made for some reason (or are taking a while to make), this button should simply be grayed out, or a "loading"-type icon should be displayed, maybe with a tooltip that informs them about the delay.

@adonahue
Copy link
Author

adonahue commented Nov 1, 2019

I will add that functionality to the story.

@adonahue
Copy link
Author

adonahue commented Nov 6, 2019

iconmonstr-note-14.svg

iconmonstr-note-32.svg

@adonahue adonahue removed the sprint candidate Please review before Planning meeting label Nov 13, 2019
@juliariffgit juliariffgit added this to the Sprint 15 milestone Nov 22, 2019
@adonahue
Copy link
Author

adonahue commented Dec 2, 2019

@jordanreedie @mlippert - what is the status of this story? I think everything here (except the icons) are deployed on staging. Is this still waiting on a code review?

@adonahue
Copy link
Author

adonahue commented Dec 3, 2019

Testing Notes:

  • New doc icons lower-priority
  • On join, document state is the same as the state on leave, not always on by default.
  • On stop share view always opens to the doc - not the previous state of the doc (either open or closed). Looking at a note in Screen Sharing with Google Docs #235 which says this was intentional as a simpler implementation.

Accepting story as-is. Verified in Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants