Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Backend now binds parametric circuits before execution #16

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

ameyer-rigetti
Copy link
Contributor

@ameyer-rigetti ameyer-rigetti commented Jul 28, 2021

NOTE: Merging into omit-barriers to release both together

Behavior implemented according to execute() docs:

parameter_binds (list[dict]): List of Parameter bindings over which the set of
    experiments will be executed. Each list element (bind) should be of the form
    ``{Parameter1: value1, Parameter2: value2, ...}``. All binds will be
    executed across all experiments, e.g. if parameter_binds is a
    length-n list, and there are m experiments, a total of :math:`m x n`
    experiments will be run (one for each experiment/bind pair).

@ameyer-rigetti ameyer-rigetti force-pushed the bind-params branch 2 times, most recently from 808bd46 to 8226e9b Compare July 28, 2021 22:44
Copy link
Contributor

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the Qiskit specifics but the Python looks good. Made a couple optional suggestions

qiskit_rigetti/_qcs_backend.py Show resolved Hide resolved
qiskit_rigetti/_qcs_backend.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants