fix(rime_levers_api.h): customize_bool() misused bool type

BREAKING CHANGE: in signature of C API function `customize_bool()`, change type `bool` to `Bool` (alias of `int`). Impact: the changed function is not in use by any first party code, known to be in use by osfans/trime.
rime · Jan 29, 2019 · 42bacc5 · 42bacc5 · lotem · Jan 30, 2019
1 parent 2a15ef4
commit 42bacc5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/rime/lever/levers_module.cc b/src/rime/lever/levers_module.cc
@@ -63,8 +63,8 @@ static Bool rime_levers_save_settings(RimeCustomSettings* settings) {
 }
 
 static Bool rime_levers_customize_bool(RimeCustomSettings* settings,
-                                       const char* key, bool value) {
-  an<ConfigItem> item = New<ConfigValue>(value);
+                                       const char* key, Bool value) {
+  an<ConfigItem> item = New<ConfigValue>(bool(value));
   auto custom_settings = reinterpret_cast<CustomSettings*>(settings);
   return custom_settings->Customize(key, item);
 }

diff --git a/src/rime_levers_api.h b/src/rime_levers_api.h
@@ -32,7 +32,7 @@ typedef struct rime_levers_api_t {
   void (*custom_settings_destroy)(RimeCustomSettings* settings);
   Bool (*load_settings)(RimeCustomSettings* settings);
   Bool (*save_settings)(RimeCustomSettings* settings);
-  Bool (*customize_bool)(RimeCustomSettings* settings, const char* key, bool value);
+  Bool (*customize_bool)(RimeCustomSettings* settings, const char* key, Bool value);
   Bool (*customize_int)(RimeCustomSettings* settings, const char* key, int value);
   Bool (*customize_double)(RimeCustomSettings* settings, const char* key, double value);
   Bool (*customize_string)(RimeCustomSettings* settings, const char* key, const char* value);