Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for format/lint #525

Open
trdthg opened this issue Oct 16, 2024 · 3 comments
Open

Add CI for format/lint #525

trdthg opened this issue Oct 16, 2024 · 3 comments

Comments

@trdthg
Copy link
Contributor

trdthg commented Oct 16, 2024

Hi, I want to add some CI to the codebase to check the code style and do some static analyze. I plan to use ruff , it will bring these benefits:

  • The code style of the current repository is inconsistent and difficult to read, formatting can alleviate this. I will also appropriately modify the format config file based on the current code to make minimal changes.
  • avoid some minor issues, such as duplicate keys in a dictionary
  • Optimize the experience for other contributors, for example (if you use vscode and have installed the plugin, and sometimes you press ctrl-c, auto-save will automatically format the code, which is quite annoying)

Is any suggestions or comments?

@trdthg trdthg changed the title Add CI for codestyle Add CI for format/check Oct 16, 2024
@trdthg trdthg changed the title Add CI for format/check Add CI for format/lint Oct 16, 2024
@trdthg
Copy link
Contributor Author

trdthg commented Oct 17, 2024

for example thinks like these: #528

@UmerShahidengr
Copy link
Collaborator

Thats a good suggestion @trdthg . Do you need any resources from our side to add changes in the CI, or will you update it yourself? If you are going to update it, then do add a PR, we will review it together and merge it.

@trdthg
Copy link
Contributor Author

trdthg commented Oct 18, 2024

Thank you, I'll send a PR later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants