Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _ in causes.csv #255

Merged
merged 1 commit into from
Jun 28, 2024
Merged

remove _ in causes.csv #255

merged 1 commit into from
Jun 28, 2024

Conversation

sequencer
Copy link
Contributor

I think these names should be aligned, not matter with _ or not with _

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (5a22f44) to head (5500518).
Report is 7 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   92.97%   92.53%   -0.45%     
==========================================
  Files           3        3              
  Lines         655      656       +1     
==========================================
- Hits          609      607       -2     
- Misses         46       49       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's illogical to use spaces for some and underscores for others.

@aswaterman aswaterman merged commit 984aced into riscv:master Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants