Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 0xFFFFFFFF instead of 0 for rs1 field in make_go #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wangpc-pp
Copy link
Contributor

The default rs1 is 0, but this may make encoding process hard to distinguish the real rs1 of an instruction.

We set it to 0xFFFFFFFF instead.

The default rs1 is 0, but this may make encoding process hard to
distinguish the real rs1 of an instruction.

We set it to 0xFFFFFFFF instead.
@wangpc-pp
Copy link
Contributor Author

cc @4a6f656c

@aswaterman
Copy link
Member

This is hacky. What about other register specifiers? What about cases where only part of the register specifier is a don't-care? (e.g. the forthcoming Zpa extension uses the LSB of some register specifiers as an opcode bit, but the other 4 bits remain significant)

@wangpc-pp
Copy link
Contributor Author

This is hacky. What about other register specifiers? What about cases where only part of the register specifier is a don't-care? (e.g. the forthcoming Zpa extension uses the LSB of some register specifiers as an opcode bit, but the other 4 bits remain significant)

Yes, you are right. This change is highly related to the implementation, I will hold it util we have decided how to implement it in Golang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants