Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against balance overflow and underflow #311

Closed
hai-rise opened this issue Sep 4, 2024 · 5 comments · Fixed by #370
Closed

Guard against balance overflow and underflow #311

hai-rise opened this issue Sep 4, 2024 · 5 comments · Fixed by #370
Assignees
@varun-doshi
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hai-rise
Copy link
Contributor

hai-rise commented Sep 4, 2024

Should use saturating_add and saturating_sub by default, and raise errors where needed.
@hai-rise hai-rise added enhancement New feature or request good first issue Good for newcomers labels Sep 4, 2024
@varun-doshi
Copy link
Contributor

I'd like to take this up

@hai-rise
Copy link
Contributor Author

@TheCactusBlue Have you started on this one 🙏 ?

@hai-rise
Copy link
Contributor Author

hai-rise commented Oct 2, 2024

@varun-doshi this one is available, can I assign you now 🙏?

@varun-doshi
Copy link
Contributor

Yes please

@varun-doshi
Copy link
Contributor

Acknowledged

@varun-doshi varun-doshi mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varun-doshi varun-doshi

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat:prevent overflow and underflow varun-doshi/pevm
2 participants
@varun-doshi @hai-rise